timvideos / edid.tv

EDID Database Website
GNU General Public License v2.0
26 stars 7 forks source link

XrandR output not recognized #6

Closed bors-ltd closed 5 years ago

bors-ltd commented 7 years ago

Hi,

I went to http://edid.tv/edid/upload/text/ after your talk at 33c3, and pasted the output of xrandr --props but the page returns with Error! No EDID was parsed.

Here is the full output, maybe the output format changed in later XrandR version.

Screen 0: minimum 320 x 200, current 1920 x 1080, maximum 8192 x 8192
LVDS-1 connected (normal left inverted right x axis y axis)
    _MUTTER_PRESENTATION_OUTPUT: 0 
    EDID: 
        00ffffffffffff000610c59c00000000
        1c130103801d12780a00000000000000
        00505400000001010101010101010101
        010101010101521c008f50202e303020
        36001eb3100000180000000100061020
        00000000000000000a20000000fe004c
        503133335758332d544c4134000000fe
        00436f6c6f72204c43440a202020001d
    scaling mode: Full aspect 
        supported: None, Full, Center, Full aspect
   1280x800      60.22 +
   1024x768      60.04    60.00  
   960x720       60.00  
   928x696       60.05  
   896x672       60.01  
   800x600       60.00    60.32    56.25  
   700x525       59.98  
   640x512       60.02  
   640x480       60.00    59.94  
   512x384       60.00  
   400x300       60.32    56.34  
   320x240       60.05  
VGA-1 disconnected (normal left inverted right x axis y axis)
HDMI-1 connected primary 1920x1080+0+0 (normal left inverted right x axis y axis) 533mm x 312mm
    EDID: 
        00ffffffffffff000469d323b74f0000
        0e16010380351f782a6ea5a3544f9f26
        115054bfef00714f8140818095008100
        81c0b300d1c0023a801871382d40582c
        450015382100001e000000ff0043344c
        4d54463032303430370a000000fd0032
        551c5311000a202020202020000000fc
        00415355532056473233410a2020008f
    _MUTTER_PRESENTATION_OUTPUT: 0 
    aspect ratio: Automatic 
        supported: Automatic, 4:3, 16:9
    Broadcast RGB: Automatic 
        supported: Automatic, Full, Limited 16:235
    audio: auto 
        supported: force-dvi, off, auto, on
   1920x1080     60.00*+
   1680x1050     59.88  
   1280x1024     75.02    60.02  
   1440x900      59.90  
   1280x960      60.00  
   1280x800      59.91  
   1152x864      75.00  
   1280x720      60.00  
   1024x768      75.03    70.07    60.00  
   832x624       74.55  
   800x600       72.19    75.00    60.32    56.25  
   640x480       75.00    72.81    66.67    59.94  
   720x400       70.08  
DP-1 disconnected (normal left inverted right x axis y axis)
    Broadcast RGB: Automatic 
        supported: Automatic, Full, Limited 16:235
    audio: auto 
        supported: force-dvi, off, auto, on
HDMI-2 disconnected (normal left inverted right x axis y axis)
    aspect ratio: Automatic 
        supported: Automatic, 4:3, 16:9
    Broadcast RGB: Automatic 
        supported: Automatic, Full, Limited 16:235
    audio: auto 
        supported: force-dvi, off, auto, on
HDMI-3 disconnected (normal left inverted right x axis y axis)
    aspect ratio: Automatic 
        supported: Automatic, 4:3, 16:9
    Broadcast RGB: Automatic 
        supported: Automatic, Full, Limited 16:235
    audio: auto 
        supported: force-dvi, off, auto, on
DP-2 disconnected (normal left inverted right x axis y axis)
    Broadcast RGB: Automatic 
        supported: Automatic, Full, Limited 16:235
    audio: auto 
        supported: force-dvi, off, auto, on
DP-3 disconnected (normal left inverted right x axis y axis)
    Broadcast RGB: Automatic 
        supported: Automatic, Full, Limited 16:235
    audio: auto 
        supported: force-dvi, off, auto, on

This is a 2011 MacBook Pro connected to a 23" Full HD Asus monitor through a miniDP-to-DVI adapter.

By the way, it's not straightforward from the homepage how to get any of these binary of hex data. Good thing I was curious enough to click on the hex page and stumbled upon the mention of XrandR.

mithro commented 7 years ago

Hi @bors-ltd,

Thanks for trying! As I mentioned in my talk, the edid database website needs a whole bunch of love and it sounds like this is one area. Any chance you would be interested in looking at the code?

The code to parse the text added in that form can be found at https://github.com/timvideos/edid.tv/blob/master/frontend/forms.py#L74

It looks like there is a test for doing xrandr output at https://github.com/timvideos/edid.tv/blob/master/frontend/django_tests/data/xrandr.log but I can't see where that is used.

bors-ltd commented 7 years ago

Hi,

I'll take a look, I'm a Python/Django developer myself, but I'm not sure about the "when". You know how it goes. :-)

cweiske commented 7 years ago

I just saw the 33c3 talk and also wanted to submit something :)

For me, xrandr --props paste also failed. Looking at the code, I saw that it checked for \tEDID: but the xrandr output actually has a space after the colon. Removing the space made the parser work, and the EDID was correctly submitted.

pp3345 commented 5 years ago

This issue should be fixed now (see https://github.com/timvideos/edid.tv/pull/34).

mithro commented 5 years ago

Yay!