search

timvideos / edid.tv

EDID Database Website
GNU General Public License v2.0
26 stars 7 forks source link

Improving the EDID Cleaner for Xrandr #8

Closed hyades closed 5 years ago

hyades commented 7 years ago

The following commits include the following -

mithro commented 7 years ago

So, it looks like the Travis build is failing. Can you see if you can fix that?

hyades commented 7 years ago

Not sure here. Seems an issue with the selenium tests which are unable to load the X environment correctly.

Firefox output: Xlib: extension "RANDR" missing on display ":99.0"

mithro commented 7 years ago

The xrandr missing is a red herring and I believe unrelated to the failure. The real failure seems to be;

[CustomizableUI]
  Custom widget with id loop-button does not return a valid node
*** Blocklist::_preloadBlocklistFile: blocklist is disabled
1484085615219 addons.manager DEBUG Starting provider: <unnamed-provider>
1484085615219 addons.manager DEBUG Registering shutdown blocker for <unnamed-provider>
1484085615219 addons.manager DEBUG Provider finished startup: <unnamed-provider>
JavaScript warning: https://normandy.cdn.mozilla.net/static/bundles/selfrepair-133d4d7c9de72117ee8e.24ec5279eef1.js, line 7: mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create
JavaScript error: https://normandy.cdn.mozilla.net/static/bundles/selfrepair-133d4d7c9de72117ee8e.24ec5279eef1.js, line 9: ReferenceError: fetch is not defined\n'
mithro commented 7 years ago

Are you able to run the tests locally on your computer?

mithro commented 5 years ago

@pp3345 Is anything in this pull request still useful? Should I close it?

pp3345 commented 5 years ago

@mithro I guess the xrandr cleaner improvements might still be useful. I'll have a look at it later and decide whether to cherry-pick some of the changes.

pp3345 commented 5 years ago

@hyades I've rebased and updated your changes to be compatible with the current version of edid.tv and created a new PR here: https://github.com/timvideos/edid.tv/pull/34 Thanks a lot for your contribution!