timvideos / streaming-system

Tim Video's - Live Streaming for user groups and other events.
https://code.timvideos.us/
Apache License 2.0
131 stars 52 forks source link

Draw graphs of the various stats we collect #18

Closed mithro closed 9 years ago

mithro commented 12 years ago

For example we collect the number of connected clients and the bitrate. It would be nice to see these over time...

ApsOps commented 10 years ago

Where and how is this data stored?

mithro commented 10 years ago

See https://github.com/timvideos/streaming-system/pull/19 -- we really just need to clean up and merge that request.

CarlFK commented 10 years ago

Tim,

Can I merge this as is?

I just skimmed the diff, it is just additions the only thing that might cause a noticed change is:

https://github.com/timvideos/streaming-system/pull/19/files#diff-19deb01fc2b9d78d055b87c9c84dcdeaR77

I suspect it is missing from the current template, and hopefully it all just merges without any collisions.

On Tue, Mar 4, 2014 at 6:55 AM, Tim Ansell notifications@github.com wrote:

See #19 https://github.com/timvideos/streaming-system/pull/19 -- we really just need to clean up and merge that request.

Reply to this email directly or view it on GitHubhttps://github.com/timvideos/streaming-system/issues/18#issuecomment-36620972 .

Carl K

mithro commented 10 years ago

Does it still work? I'm unsure if the database structure has changed since this request was sent.

I was also a little worried about the extra dependencies and wanted to look at them closer to make sure it is all good. On 5 Mar 2014 05:36, "Carl Karsten" notifications@github.com wrote:

Tim,

Can I merge this as is?

I just skimmed the diff, it is just additions the only thing that might cause a noticed change is:

https://github.com/timvideos/streaming-system/pull/19/files#diff-19deb01fc2b9d78d055b87c9c84dcdeaR77

I suspect it is missing from the current template, and hopefully it all just merges without any collisions.

On Tue, Mar 4, 2014 at 6:55 AM, Tim Ansell notifications@github.com wrote:

See #19 https://github.com/timvideos/streaming-system/pull/19 -- we really just need to clean up and merge that request.

Reply to this email directly or view it on GitHub< https://github.com/timvideos/streaming-system/issues/18#issuecomment-36620972

.

Carl K

— Reply to this email directly or view it on GitHubhttps://github.com/timvideos/streaming-system/issues/18#issuecomment-36657870 .

CarlFK commented 10 years ago

I am not sure how to test that it works. But I am sure it won't break anyting.

I checked Endpoint.lastseen still exists

On Tue, Mar 4, 2014 at 9:22 PM, Tim Ansell notifications@github.com wrote:

Does it still work? I'm unsure if the database structure has changed since this request was sent.

I was also a little worried about the extra dependencies and wanted to look at them closer to make sure it is all good. On 5 Mar 2014 05:36, "Carl Karsten" notifications@github.com wrote:

Tim,

Can I merge this as is?

I just skimmed the diff, it is just additions the only thing that might cause a noticed change is:

https://github.com/timvideos/streaming-system/pull/19/files#diff-19deb01fc2b9d78d055b87c9c84dcdeaR77

I suspect it is missing from the current template, and hopefully it all just merges without any collisions.

On Tue, Mar 4, 2014 at 6:55 AM, Tim Ansell notifications@github.com wrote:

See #19 https://github.com/timvideos/streaming-system/pull/19 -- we really just need to clean up and merge that request.

Reply to this email directly or view it on GitHub<

https://github.com/timvideos/streaming-system/issues/18#issuecomment-36620972

.

Carl K

Reply to this email directly or view it on GitHub< https://github.com/timvideos/streaming-system/issues/18#issuecomment-36657870

.

Reply to this email directly or view it on GitHub.

Carl K

timsvideo-portable commented 10 years ago

On 5 March 2014 16:49, Carl Karsten notifications@github.com wrote:

I am not sure how to test that it works. But I am sure it won't break anyting

I'd think you could do something like;

Atleast you'll see if you get any errors....

Tim

codersquid commented 10 years ago

@aps-sids are you comfortable trying what Tim suggests in the previous comment?

ApsOps commented 10 years ago

I tested the code. Here's the screenshot of graphs page. Since this is quite old, some other things (like switch to class based views I guess) have changed. We need to take care while merging this.

timvideos-graph-test

mithro commented 10 years ago

I'm leave this issue open until we use this feature in production and confirm it is working as intended.

ApsOps commented 10 years ago

Improve the existing graphs using Chart.js | Open source HTML5 Charts for your website