timvideos / streaming-system

Tim Video's - Live Streaming for user groups and other events.
https://code.timvideos.us/
Apache License 2.0
131 stars 52 forks source link

Added config.private.json.example #50

Closed luke-john closed 10 years ago

luke-john commented 10 years ago

The file config.private.json.example should act as a template for config.private.json

For more information see Issue #48

mithro commented 10 years ago

This should remove the correct lines from config.json

luke-john commented 10 years ago

Sorry, i'm a little uncertain which lines should be removed from config.json,

If it's just getting used for testing should everything except the keys ["config", "default", "av"] be removed?

mithro commented 10 years ago

Just config and default should work.

luke-john commented 10 years ago

Should the default still use pycon or should it be something like EVENT?

https://github.com/timvideos/streaming-system/blob/master/config.json#L17-L22

mithro commented 10 years ago

EVENT probably.

luke-john commented 10 years ago

Okay, this will actually cause a JavaScript error with in the current web interface code if that url not exist.

mithro commented 10 years ago

Actually, maybe we should just use timvideos as the holder so that the URLs still work?

luke-john commented 10 years ago

I think thats a better idea, i'll update that now.

luke-john commented 10 years ago

So I've updated those urls and added a default logo.

works

doesn't work

https://github.com/lukejohnosmahi/streaming-system/blob/add/master/config.private.json.example/config.json#L17-L22

mithro commented 10 years ago

TimVideos logos at https://drive.google.com/folderview?id=0B5VlNZ_Rvdw6dGpjWnZOZURtS1U&usp=sharing Favicon already in the repository at https://github.com/timvideos/streaming-system/blob/master/website/frontend/static/img/favicon.ico

luke-john commented 10 years ago

great, I've set the default logo to logo.jpg from https://drive.google.com/a/osmahi.com/folderview?id=0B5VlNZ_Rvdw6dGpjWnZOZURtS1U&usp=sharing#.

luke-john commented 10 years ago

Once I get to update the front-end, i'll likely update the logo to use the new dimensions.

luke-john commented 10 years ago

Should I add an av room back into https://github.com/timvideos/streaming-system/blob/master/config.json or update https://github.com/timvideos/streaming-system/blob/master/tools/register/fake_register.py#L26 to use default instead of av?

https://github.com/timvideos/streaming-system/pull/52#discussion_r8358397