search

timvideos / streaming-system

Tim Video's - Live Streaming for user groups and other events.
https://code.timvideos.us/
Apache License 2.0
131 stars 52 forks source link

vagrant to demonstrate install #57

Open CarlFK opened 10 years ago

mithro commented 10 years ago

Can you fix the spelling / punctuation in the commit messages?

You can use git rebase --interactive and then mark the patch as "edit". You can also use that to squash patches together.

CarlFK commented 10 years ago

I think I cleaned up all the things you mentioned.

mithro commented 9 years ago

Hi @CarlFK

This pull request no longer merges. Can you please rebase onto the latest and then I'll try merging it.

Tim

mithro commented 9 years ago

Reopening pull request because it commits were never merged. Need to figure out if we should remove the commits from @CarlFK repo or do something more.

mithro commented 9 years ago

@CarlFK poke?

CarlFK commented 9 years ago

I did this so GSOC students could verify that the install process works. I don't see much value in it now, so just ignore it.

On Sat, Jan 31, 2015 at 8:58 AM, Tim Ansell notifications@github.com wrote:

@CarlFK https://github.com/CarlFK poke?

— Reply to this email directly or view it on GitHub https://github.com/timvideos/streaming-system/pull/57#issuecomment-72320859 .

Carl K

timsvideo-portable commented 9 years ago

There is another set of GSoC students only a month or two away from now, will they find it useful?

There were also some other changes in here you made to make the install more automated which I think are worth rescusing.

On 1 February 2015 at 02:07, Carl Karsten notifications@github.com wrote:

I did this so GSOC students could verify that the install process works. I don't see much value in it now, so just ignore it.

On Sat, Jan 31, 2015 at 8:58 AM, Tim Ansell notifications@github.com wrote:

@CarlFK https://github.com/CarlFK poke?

— Reply to this email directly or view it on GitHub < https://github.com/timvideos/streaming-system/pull/57#issuecomment-72320859>

.

Carl K

— Reply to this email directly or view it on GitHub https://github.com/timvideos/streaming-system/pull/57#issuecomment-72321201 .

CarlFK commented 9 years ago

I suspect the install is more complicated than it needs to be.

There are 2 cases:

  1. install into production on a fresh ubunu 10.04 box.
  2. install for development on some screwy laptop.

Those don't need to be the same script. If someone wants to install into production on something else, they can make the changes needed for whatever it is they are doing.

given that, I think we need to refactor the install process. Last year I did my best not to touch it so I didn't introduce any problems which would scare off anyone evaluating the project.

You / apps should have a good idea what the requirements are. put them in a script.

On Sat, Jan 31, 2015 at 9:41 AM, timsvideo-portable < notifications@github.com> wrote:

There is another set of GSoC students only a month or two away from now, will they find it useful?

There were also some other changes in here you made to make the install more automated which I think are worth rescusing.

On 1 February 2015 at 02:07, Carl Karsten notifications@github.com wrote:

I did this so GSOC students could verify that the install process works. I don't see much value in it now, so just ignore it.

On Sat, Jan 31, 2015 at 8:58 AM, Tim Ansell notifications@github.com wrote:

@CarlFK https://github.com/CarlFK poke?

— Reply to this email directly or view it on GitHub <

https://github.com/timvideos/streaming-system/pull/57#issuecomment-72320859>

.

Carl K

— Reply to this email directly or view it on GitHub < https://github.com/timvideos/streaming-system/pull/57#issuecomment-72321201>

.

— Reply to this email directly or view it on GitHub https://github.com/timvideos/streaming-system/pull/57#issuecomment-72322580 .

Carl K