Multiple Bootstrap related UI tweakings

timvideos / streaming-system

Tim Video's - Live Streaming for user groups and other events.

https://code.timvideos.us/

Apache License 2.0

131 stars 52 forks source link

Multiple Bootstrap related UI tweakings #94

Closed micolous closed 9 years ago

micolous commented 9 years ago

Started working on getting some more info about the current talk in the navbar.
Removed HTML injection issues from the event feeds, making them all use the "generated" tag instead.
Disallowed HTML in the event feed JSON output generator.
Navbar is now white.
Add LCA logo.
Remove padding between elements.
Fix URLs for Zookeepr source.

mithro commented 9 years ago

Still two open things here;

Lower all the keys
Confirm the webchat thing prevents leaving the page when logged in
Why are you removing all the formatting things?

micolous commented 9 years ago

There's more than case sensitivity that is an issue for the Zookeepr schema -- unfortunately is not that simple.

The webchat blocks navigation if logged in, but not if it is not logged in.

The formatting things are replaced with a much saner implementation in JavaScript directly, and now calls .text instead of .html. This means that the event feed no longer has potential for HTML injection issues, because we don't actually bother to sanitise that input data.

mithro commented 9 years ago

There's more than case sensitivity that is an issue for the Zookeepr schema -- unfortunately is not that simple.

Lets worry about getting Zookeepr fixed another time.

The formatting things are replaced with a much saner implementation in JavaScript directly, and now calls .text instead of .html. This means that the event feed no longer has potential for HTML injection issues, because we don't actually bother to sanitise that input data.

We trust data from zookeepr and we generate ourselves. We also have no "user data" to steal, so injection isn't really an issue. I'm going to merge this, but we should probably look at rolling back this bit.