timvink / mkdocs-git-authors-plugin

MkDocs plugin to display git authors of a page.
https://timvink.github.io/mkdocs-git-authors-plugin
MIT License
90 stars 20 forks source link

Authorship_threshold_percent ignored #72

Open christophhillisch opened 1 year ago

christophhillisch commented 1 year ago

I am running into the problem that configurations beyond the first one (show_contribution: true) are ignored. I set authorship_threshold_percent: 10, but I found contributions of 0.88 %.

Package Versions:

Relevant parts in mkdocs.yml:

plugins:
  - search:
      lang: en
  - git-revision-date-localized:
      enable_creation_date: true
      fallback_to_build_date: false
      timezone: Europe/Paris
  - git-authors:
      show_contribution: true
      sort_authors_by: contribution
      authorship_threshold_percent: 10
xsa commented 1 year ago

I'm seeing the same behaviour where contributors below the threshold are still shown.

Also, when using sort_authors_by: contribution instead of name, it does not sort them by name anymore, but the order (%) of contribution is not correct.

Using:

aazraq commented 1 year ago

I also have the same issue.

timvink commented 1 year ago

Thanks for reporting, I will need to look into this when I can make time again.