search

timvink / mkdocs-git-revision-date-localized-plugin

MkDocs plugin to add a last updated date to your site pages
https://timvink.github.io/mkdocs-git-revision-date-localized-plugin/index.html
MIT License
193 stars 39 forks source link

1.2.3 breaks integration with Material for MkDocs #127

Closed squidfunk closed 6 months ago

squidfunk commented 6 months ago

Sadly, the latest release breaks the integration with Material for MkDocs. I'm not sure what we need to do here other than to tell our users to downgrade to 1.2.2, because until now, it is completely unclear how a migration path should look. I might be missing something, but the maintainers of MkDocs have yet not provided instructions how to make themes and plugins downward compatible. It is the exact reason I'm raising awareness

Downstream issue: https://github.com/squidfunk/mkdocs-material/issues/6734

timvink commented 6 months ago

Thanks for letting me know. Will revert and make a new release soon

oprypin commented 6 months ago

@timvink Sorry about the bad change, this was supposed to be about forwards compatibility but instead made a separate breakage. Could I try to make the change again but correctly this time 🥺 https://github.com/timvink/mkdocs-git-revision-date-localized-plugin/pull/126#discussion_r1477012765

timvink commented 6 months ago

No worries, it's on me, I should have tested more.

Let's try again 👍

timvink commented 6 months ago

It's released

oprypin commented 6 months ago

Let's try again 👍

Thank you. The reland is ready for your consideration https://github.com/timvink/mkdocs-git-revision-date-localized-plugin/pull/128