timvink / mkdocs-git-revision-date-localized-plugin

MkDocs plugin to add a last updated date to your site pages
https://timvink.github.io/mkdocs-git-revision-date-localized-plugin/index.html
MIT License
193 stars 39 forks source link

Adds use_file_dates option for non git use #129

Closed Dschogo closed 5 months ago

Dschogo commented 5 months ago

This PR adds a new option, use_file_dates. When set to true, this option allows the plugin to use the file creation or modification date as the timestamps instead of retrieving it from the git log.

Useful for non git projects

timvink commented 5 months ago

Hi @Dschogo ,

Appreciate the effort you put in!

In this case it would have been better if you had discussed the change first:

https://github.com/timvink/mkdocs-git-revision-date-localized-plugin/blob/af27290b2d88a309903b786e60c0aba0e7cae674/CONTRIBUTING.md?plain=1#L5

I don't think we should add this option:

I would recommend forking this project, and removing all of the git related code, and releasing a new plugin. It's MIT licensed, so not a problem.

So, closing this PR.