Closed AndreasBieber closed 4 years ago
Thanks for your contribution! Nice work!
Elegant solution. I briefly thought there might be a performance hit by determining a repo for each file, but you solved that nicely by caching the directory of a file, so should be fine.
Just one question, is there any reason you choose to put this line in get_revision_date_for_file()
instead of _get_repo()
?
Yes, because the realpath
is also needed when calling log
. Otherwise git will complain that the path is outside of the repository.
Thanks @AndreasBieber 🎉
Will release a new version of this plugin tomorrow
Thx for the fast response and merge!
This PR adds support for symlinks (e.g. having git submodules in the
repo
):