timvink / mkdocs-git-revision-date-localized-plugin

MkDocs plugin to add a last updated date to your site pages
https://timvink.github.io/mkdocs-git-revision-date-localized-plugin/index.html
MIT License
206 stars 44 forks source link

README Dead Link Update #71

Closed Rwarcards762 closed 2 years ago

Rwarcards762 commented 2 years ago

Hi, I noticed that the "Change your CI Settings" section has a dead link in relation to GitLab Runners (in reference to the GIT_DEPTH variable.)

The link should likely be updated to one of the following below:

This is something minor, but easy to fix and figured I would mention it. Thanks!

timvink commented 2 years ago

Thanks for letting me know! Would you like provide a PR?

See https://opensource.com/article/19/7/create-pull-request-github in case you havent done this before.

Rwarcards762 commented 2 years ago

Only comment -- it seems the docs/index.md pulls in README.md but hasn't been regenerated with the commit, causing it to still have an invalid link. I assume it can just wait until the next time the site is regenerated with a change :)

timvink commented 2 years ago

Good point. Couldn't do that from mobile. New docs are live now (I ran mkdocs gh-deploy)