search

timvisee / ffsend

:mailbox_with_mail: Easily and securely share files from the command line. A fully featured Firefox Send client.
https://gitlab.com/timvisee/ffsend
GNU General Public License v3.0
6.92k stars 182 forks source link

deprecated associated function in build #126

Open mikemadden42 opened 3 years ago

mikemadden42 commented 3 years ago 
$ rustc --version
rustc 1.52.1 (9bc8c42bb 2021-05-09)

$ sw_vers
ProductName:    macOS
ProductVersion: 11.3.1
BuildVersion:   20E241

I see this warning from cargo build --release:

   Compiling reqwest v0.11.3
warning: use of deprecated associated function `failure::Fail::causes`: please use the 'iter_chain()' method instead
  --> src/util.rs:59:10
   |
59 |         .causes()
   |          ^^^^^^
   |
   = note: `#[warn(deprecated)]` on by default

warning: 1 warning emitted
timvisee commented 3 years ago

Thanks for the report. This shows up on all systems and configurations.

This is related to error handling. In order to properly fix this I'd like to upgrade to using the thiserror and anyhow crates (like I've done with prs).

I currently have limited time available, sadly. Fixing this as suggested requires some time for plumbing work. As it's a low priority thing I'll leave it open for a later moment to fix.

This has also been reported here: https://gitlab.com/timvisee/ffsend/-/issues/110