timvisee / ffsend

:mailbox_with_mail: Easily and securely share files from the command line. A fully featured Firefox Send client.
https://gitlab.com/timvisee/ffsend
GNU General Public License v3.0
6.92k stars 182 forks source link

Add another parameter to the ws API #132

Closed dylangerdaly closed 2 years ago

dylangerdaly commented 2 years ago

Hi,

I've added a password string to the ws API, the server uses this to either allow or deny the upload, I can't seem to see where this data is sent via ffend. Screenshot_2021-11-22_10-25-50

This works great with the JS version of Send however I can't seem to add this to ffsend

The string dlimit doesn't even exist in the ffsend repo?

I assume I'd need to add it here -> https://github.com/timvisee/ffsend/blob/master/src/action/upload.rs#L338

timvisee commented 2 years ago

The string dlimit doesn't even exist in the ffsend repo?

I assume I'd need to add it here -> https://github.com/timvisee/ffsend/blob/master/src/action/upload.rs#L338

ffsend is broken up into two parts. This CLI repository, and the API crate ffsend-api.

The dlimit property is set within the API crate, which explains why you couldn't find it in this repository.

This CLI application starts the upload here, after which the API crate handles the actual upload.

This is somewhat messy, sorry for that. I never had the time to properly clean things up.

dylangerdaly commented 2 years ago

Fantastic, thank you, I'll play with this today!

Nice job on all of this btw :+1:

timvisee commented 2 years ago

Thanks! Feel free to post here if you need any further guidance.