replace external call to fzf with skim

timvisee / prs

🔐 A secure, fast & convenient password manager CLI using GPG and git to sync.

https://gitlab.com/timvisee/prs

GNU General Public License v3.0

211 stars 8 forks source link

replace external call to fzf with skim #18

Closed colemickens closed 1 year ago

colemickens commented 1 year ago

Hi.

Prs.exe on windows currently fails in some scenarios since I don't have FZF installed. I think it would be great if FZF were replaced with Skim, a Rust equivalent:

https://github.com/lotabout/skim

Thank you!

timvisee commented 1 year ago

prs uses skim, but it is not supported on Windows. Therefore it chooses to use fzf on Windows as alternative.

This issue describes that skim is still not available on Windows: https://github.com/lotabout/skim/issues/293

colemickens commented 1 year ago

Oh no... thanks for the fast courteous response, sorry I hadn't found that first! (Not sure if you want to keep this open or not, I'll let you decide).

Thanks!

timvisee commented 1 year ago

Since I don't think Windows support will ever be added to skim I'll close this now.

Feel free to open this again if you have another suggestion to improve on this.