timvisee / prs

🔐 A secure, fast & convenient password manager CLI using GPG and git to sync.
https://gitlab.com/timvisee/prs
GNU General Public License v3.0
218 stars 8 forks source link

Incorrect reference, and a question #33

Closed ArielHorwitz closed 4 weeks ago

ArielHorwitz commented 1 month ago

https://github.com/timvisee/prs/blob/3d33d9dc5b842560773d337868ccd60d9130d15c/README.md?plain=1#L491

Just a small copy error, the line on madvice references the page for mlock.

I am opening an issue instead of a PR because I actually have a question I was hoping you can answer 🙏 I am trying to understand where the mlock and madvice are implemented, and I would love a pointer to this in the source code. From there I would be glad to do my own research. Thanks in advance!

timvisee commented 1 month ago

Of course!

prs depends on the secstr as secure container. It takes care of using madvice and mlock.

References:

Just a small copy error, the line on madvice references the page for mlock.

Thanks!

timvisee commented 1 month ago

I've quickly patched the incorrect reference here: https://github.com/timvisee/prs/commit/92d116ed2f6d908e873c8e691709eca7d8853ec5

ArielHorwitz commented 4 weeks ago

Thank you very much :)