search

timwaters / omniauth-mediawiki

MediaWiki OAuth strategy for Omniauth, used for all wikimedia.org wikis (e.g. commons.wikimedia.org , wikipedia.org) with the oauth extension installed
Other
4 stars 9 forks source link

Bump jwt version to 2.x #7

Closed tomhughes closed 5 years ago

tomhughes commented 5 years ago

This is needed for openstreetmap.org as we have both omniauth-google-oauth2 and omniauth-mediawiki installed and the latest version of omniauth-google-oauth2 requires jwt 2.x which creates a conflict when resolving the bundle.

I don't think there are any compatibility issues - in omniauth-google-oauth2 they had to manually verify the claims after the decode because they are passing false for verification when decoding and jwt 2.x no longer verifies the claims in that case but that doesn't apply here.

timwaters commented 5 years ago

many thanks!

timwaters commented 5 years ago

I've added this to the 0.0.4 gem