Closed timwis closed 1 year ago
Oh, turns out the org repo was working. I was just naming the repo <org-name>
when I should have been naming it <org-name>.github.io
. Doh!
So then this PR is ready for review. Once it's merged, I'll enable it on the main JKAN repo, which should make it enabled by default for future forks.
Thanks for testing. Hopefully once I add the branch to the environments tab on this repo, it won't be necessary to do so on forks 🤞🏻
Per #199, this uses the latest approach to deploying to GitHub Pages (for users who will still prefer to use GitHub Pages over Netlify).
This is based on GitHub's starter workflow for deploying jekyll sites to GitHub Pages
I've got it passing a couple env vars for the github-metadata gem, and the correct branch so that the editor works properly, but the "Edit on GitHub" link is still broken if the fork uses a different default branch from the upstream (an issue with the github-metadata gem).
The main thing I still need to figure out is how to get it to work with user/org pages (instead of repo) pages. For some reason it still gets deployed to
<org-name>.github.io/org-name
instead of just<org-name>.github.io
.To test:
.github.workflows/github-pages.yml
, changing the branch on L12 fromgh-pages
to the name of this branch (github-actions-deploy-pages
)Note that if you want to test editing functionality you'll need to point it to an oauth server per the readme.