timwis / jkan

A lightweight, backend-free open data portal, powered by Jekyll
https://jkan.io
MIT License
218 stars 310 forks source link

Add npm to docker container and instructions for use #259

Closed BryanQuigley closed 1 year ago

BryanQuigley commented 1 year ago

The previous instructions assume we have jekyll-npm which I'm open to doing instead.

Drop hadolint check as well.

netlify[bot] commented 1 year ago

Deploy Preview for jkan-demo ready!

Name Link
Latest commit 0bf8584fc2ea9010ac4f777ab20896f2320669b8
Latest deploy log https://app.netlify.com/sites/jkan-demo/deploys/64188e4176945e00087c5155
Deploy Preview https://deploy-preview-259--jkan-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

BryanQuigley commented 1 year ago

Happy to switch to jekyll-npm if that's what you prefer.

timwis commented 1 year ago

Looks good - just left a couple suggestions; happy for you to merge when ready