search

timwis / vizwit

An interactive data visualization tool
http://vizwit.io
GNU General Public License v2.0
100 stars 35 forks source link

Table text search results paging issue #175

Closed shua123 closed 7 years ago

shua123 commented 8 years ago

When using the table search box the results count and page links do not seem to be updating.

(using http://vizw.it/?gist=a304ce8fac9c14dfbf16) image

Working example when filtering through another card: image

marks commented 8 years ago

@shua123 I see that too.. thanks for logging the bug. I found a fix (see commit above) but I'm not sure if it's the most efficient or "the right way" so need to defer to @timwis for his expertise.

Demo:

um4txgkosa

timwis commented 8 years ago

Thanks for reporting @shua123! @marks, looks like you've got it fixed. Do you mind submitting a PR?

marks commented 8 years ago

PR: https://github.com/timwis/vizwit/pull/180