timwis / vizwit

An interactive data visualization tool
http://vizwit.io
GNU General Public License v2.0
100 stars 35 forks source link

Remove filtered dataset when no filters remain #194

Closed timwis closed 6 years ago

timwis commented 7 years ago

Currently, it still puts the filtered dataset on top of the totals dataset; it just happens to have the same value, so it's hard to notice.

At the moment, there's a bug in Chart.js (chartjs/Chart.js#3791) preventing us from doing this. But once it's resolved, we can simply check for the presence of filters inside Carto.js's componentWillReceiveProps method.

timwis commented 6 years ago

Not relevant with plottable.js