Add line & donut chart - Githubissues

timwis / vizwit

An interactive data visualization tool

http://vizwit.io

GNU General Public License v2.0

99 stars 36 forks source link

Add line & donut chart #94

Open timwis opened 8 years ago

timwis commented 8 years ago

Really just a matter of changing one config line in the bar & pie charts, respectively

marks commented 8 years ago

@timwis: I've been looking at how to do this but am not seeing how to use an additional card config key-value pair (like chartSubtype) to inform/change the chart settings. Suggestions on how to achieve this?

Line: for this, I think we just need to remove the fillAlpha from the graph settings
Pie: I believe the "pie" is actually already a donut since there is an inner radius (so let's have a config key that lets the radius to be passed in (and if there is none, it will be a pie)

timwis commented 8 years ago

yes @marks I agree -- I think I was originally thinking that a user configuring the json file wouldn't need to know that "bar" and "line" are based on the same code; they'd just specify which one they want as the chartType rather than subtype