search

timydaley / preseq_dev

development repository for preseq
1 stars 0 forks source link

Functions that should be removed from class definition #1

Open andrewdavidsmith opened 10 years ago

andrewdavidsmith commented 10 years ago

I think functions like expected zeros should be removed from the class definition. They don't need the private data of the class.

timydaley commented 10 years ago

Are you talking about ZTNB class? Because that uses private parameters of the class.

On Thu, Jun 12, 2014 at 1:40 PM, Andrew Smith notifications@github.com wrote:

I think functions like expected zeros should be removed from the class definition. They don't need the private data of the class.

— Reply to this email directly or view it on GitHub https://github.com/timydaley/preseq_dev/issues/1.

Timothy Daley University of Southern California

andrewdavidsmith commented 10 years ago

Not from what I see. It seems you just use the accessors, and those are trivial. It seems like no reason to keep the functions within the class. They would not be used by a typical person wanting to use a ZTNB outside of the relatively narrow capture-recapture context.