search

tin2tin / Blender_Screenwriter

Blender add-on for writing screenplays and convert them directly into timed storyboards.
190 stars 20 forks source link

overlap of dialog when creating scene strips #14

Closed samytichadou closed 4 years ago

samytichadou commented 4 years ago

Hi, on linux 19.04 and blender 2.82 (-e5b788bad8bc-linux-glibc217-x86_64), when creating scene strips from the script you put in the latest zip release, i get some overlapping dialog at 01'05"02 image Here's what it gives when putting the first dialog one channel up I took a look at the script and i don't think it is wanted. Appart from that , this is a great tool sir ! thanks a lot !

AndreaMonzini commented 4 years ago

If you look the at the python script ( for what i understand ) the duration and in_timedepend on characters_pr_minute = 900 and lines_pr_minute = 59 In details:

duration = int(((len(f.original_content)/characters_pr_minute)*60)*fps)
                in_time = int(((f.original_line/lines_pr_minute)*60)*fps)

Anyway it is just an initial development.

samytichadou commented 4 years ago

@AndreaMonzini yeah of course ! it was not some complaining of any kind just result of early test for me, i didn't know if you guys were aware of this issue ! thanks for the answer

AndreaMonzini commented 4 years ago

Actually i am learning Python and i just tried to explain to myself too :) Any help is super welcomed, thank you for the report !

tin2tin commented 4 years ago

That should be an easy fix once the multi-file commit is ready to be patched(missing join).

tin2tin commented 4 years ago

I'm not able to reproduce this one. What's your project fps?

AndreaMonzini commented 4 years ago

Hi, i can reproduce it, 24 fps :

overlap

tin2tin commented 4 years ago

Fixed: https://github.com/tin2tin/Blender_Screenwriter/commit/9904d8200d94f647adc96547cb117c02c7717341