🖼️ Images - Assets not displayed when running `pnpm start`

tinacms / tina-cloud-starter

Next.js starter for TinaCMS: live edit your website visually 🪄

https://tina-cloud-starter-orcin.vercel.app/

Apache License 2.0

234 stars 376 forks source link

🖼️ Images - Assets not displayed when running `pnpm start` #542

Closed ncn-ssw closed 1 month ago

ncn-ssw commented 1 month ago

When connected to TinaCloud using pnpm start, images are not displayed during editing as they are being pulled from the Media Manager.

Figure: The Tina Starter with no image

Tasks

[x] Correct mangling of image URLs
[x] Improve instructions on how to set up the start with TinaCloud such that they include directions on how to setup media manager.

ncn-ssw commented 1 month ago

This problem appears to be related to https://github.com/tinacms/tinacms/issues/4801

[x] Ensure https://github.com/tinacms/tinacms/issues/4801 is closed upon completion of this item

ncn-ssw commented 1 month ago

I have still not determined the root cause yet.

Testing with TinaCloud back to the merging of https://github.com/tinacms/tinacloud/pull/2105 indicates that the issue existed as far back as 19 July 2024.
The existence of https://github.com/tinacms/tinacms/issues/4465 suggests the bug may have been present as of March 2024
So far, the only operation producing the full URL I can find is at https://github.com/tinacms/tinacms/blob/2762994587c1b97bdd8c188da70b1f8532d5da4a/packages/tinacms/src/toolkit/core/media-store.default.ts#L181

I intend to continue the investigation Monday 23 September 2024.

JackDevAU commented 1 month ago

Could be related to https://github.com/tinacms/tinacms/issues/4817

ncn-ssw commented 1 month ago

A fix by @kldavis4 has been deployed to TinaCloud to ensure that images are stored at the locations given by the original image URLs.

If you experience this issue, resync your media - your media will be placed in the correct locations.

Figure: Location of the "Resync Media" button within a Project on the Media tab

ncn-ssw commented 1 month ago

PBI to be raised to enable media management automatically when using the TinaCloud Starter template.

ncn-ssw commented 1 month ago

✅ Done - PBI that was raised - https://github.com/tinacms/tinacms/issues/5166

ncn-ssw commented 1 month ago

This problem appears to be related to tinacms/tinacms#4801

[x] Ensure 🐛 Tina cloud - Some images are not found #2159 tinacms#4801 is closed upon completion of this item

To be closed by author of issue when happy.