💸 Tech Debt – The Compare Box (Hard Coded "Join Table")

tinacms / tina.io

Website for TinaCMS 🦙 - General info, documentation, blogs & contribution guidelines.

246 stars 1.59k forks source link

Pain 🩸

The current compare box block has implementation issues, which make the editing experience bad and inflexible. These are all problems with the boolean "list" (hard coded length) in the "Companies" object in the schema – this controls whether a "Company" satisfies the criteria at a specific index in the criteria list.

There can be any number of criteria, but always 10 booleans in each companies editor
Each boolean in the companies editor is un-labeled
Criteria is totally decoupled from the Changing the order or data of the criteria. i.e. If you change the criteria order, you need to go into every company and reset the booleans to match. If you change criteria text, it still has all the old boolean settings in each company object.

See screenshots below for the specific problem.

Tasks

I've started work on this, to see current solution (using BeforeSubmit to reach in and synch values) see the branch... tina/repo-based-media.

[x] Check with Jack P about data passing between Tina form fields (I suspect this has been made difficult intentionally).
[x] Come up with a solution + custom components such that... boolean list syncs up to the criteria list in terms of length and label.

Acceptance Criteria

[x] Changing the criteria list order makes equivalent changes to the company boolean list.
[x] Boolean list is labelled based on the criteria.
[x] Boolean list length matches criteria list length.

Screenshots 📸

Figure – we have a list of criteria

Figure – we have a list of things to compare (e.g. companies) – same level of nesting as the criteria list

Figure – ❌ ❌ ❌ the bad, each thing to compare has a column of booleans to be mapped to the criteria

[https://outlook-1.cdn.office.net/assets/reaction/heart.png] Landon Maxwell [SSW] reacted to your message:

[cid:ssw-circle(1)_4c7259a6-23f6-49e5-b933-230ca304562e.png]

Landon Maxwell SSW Multimedia Specialist/Videographer Stalk: SSW Peoplehttps://www.ssw.com.au/people/Landon-Maxwell?utm_source=emailsignature | Walk: SSW Melbournehttps://www.ssw.com.au/ssw/Company/Offices/?utm_source=emailsignature | Talk: +61 425 360 959https://www.ssw.com.au/ssw/Company/ContactUs.aspx [cid:youtube-icon_b8b5cda9-a973-4973-8763-cf3d4922e060.png] https://www.youtube.com/c/SSWTV [cid:linkedin-icon_b153ac9a-eb66-47d9-9c51-ad20b42b8a0a.png] https://www.linkedin.com/company/ssw/ [cid:x-logo_3eb6d0d3-24fb-487d-a4a7-2e30cddc1ebf.png] https://x.com/SSW_TV [cid:teams-icon_552803c2-9c44-4267-b563-7fe1a7a0e589.png] @.***>

    TinaCMS, the #1 CMS on GitHub, is now part of the SSW family<https://adamcogan.com/2024/05/15/ssw-purchases-tinacms?utm_source=emailsignature>

From: Isaac Lombard [SSW] @.> Sent: Friday, November 15, 2024 12:14:30 AM To: tinacms/tina.io @.> Cc: Landon Maxwell [SSW] @.>; Assign @.> Subject: Re: [tinacms/tina.io] 💸 Tech Debt – The Compare Box (Hard Coded "Join Table") (Issue #2456)

See PR #2439https://github.com/tinacms/tina.io/pull/2439 – proud of this one

— Reply to this email directly, view it on GitHubhttps://github.com/tinacms/tina.io/issues/2456#issuecomment-2477673215, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASUEEVZWWE3WLOGNS3V4DAT2AU4GNAVCNFSM6AAAAABRVHPVTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZXGY3TGMRRGU. You are receiving this because you were assigned.Message ID: @.***>

tinacms / tina.io