tinacms / tinacms

A fully open-source headless CMS that supports Markdown and Visual Editing
https://tina.io
Apache License 2.0
11.19k stars 562 forks source link

fix: UI mobile stretched beyond screen size [4163] #4425

Closed FatahChan closed 1 month ago

FatahChan commented 4 months ago

Fixed issue 4163: Content creation UI on mobile is starched beyond the screen size by change the style from flex-1 to w-full, then added dynamic top padding so it doesn't conflict with hamburger menu

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: a035ab89f83f3b37a872b8fe613ab9db55f19302

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages | Name | Type | | ---------------------------- | ----- | | tinacms | Patch | | next-tinacms-cloudinary | Patch | | next-tinacms-dos | Patch | | next-tinacms-s3 | Patch | | tinacms-authjs | Patch | | tinacms-clerk | Patch | | @tinacms/app | Patch | | @tinacms/cli | Patch | | @tinacms/vercel-previews | Patch | | starter-basic-iframe | Patch | | starter-empty | Patch | | e2e-next | Patch | | @tinacms/self-hosted-starter | Patch | | kitchen-sink-starter | Patch | | @tinacms/starter | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

FatahChan commented 3 months ago

@jeffsee55

hello, This is my first time contributing to open source.

I was wondering if I am missing a step to get a review, checked the contribution.md, I didn't see anything about the PR process.

Sorry if there is something obvious that I missed

Thanks in advance

bojanvidanovic commented 2 months ago

Can this get merged? @kldavis4

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

BrookJeynes commented 1 month ago

Hey @FatahChan, the change looks good.

For future reference, could you please include a screenshot when you make style updates as it helps with visualising the changes 🙏

I think the dynamic top padding might not be necessary, so I've gone ahead and removed it. Was there something this was fixing?

Merging as this looks good though, great work!

Thanks,