Bug: Date picker field is broken and crashes (Tinasaurus)

hrueger commented 1 year ago

Describe the issue that you're seeing. Any Loom videos or screenshots usually help a lot!

I'm using the base tinasaurus project. When editing a post of the blog and changing the Date field, behaviour is as follows:

When selecting a date, it shows required and Save is disabled:
When deleting the field content (Ctrl+A and Delete) and typing (e.g. s for september), the whole page crashes and we get a date value is not finite in DateTimeFormat.format():

Reproduction

https://github.com/tinacms/tinasaurus

Steps to reproduce

Clone the tinasaurus project, start it and edit the date field of a blog post (see above on what errors to expect).

System Info

System:
    OS: Windows 10 10.0.22621
    CPU: (16) x64 12th Gen Intel(R) Core(TM) i7-1260P
    Memory: 4.24 GB / 15.62 GB
  Binaries:
    Node: 18.16.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - C:\_Source\docs\node_modules\.bin\yarn.CMD
    npm: 9.5.1 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.22621.2215.0), Chromium (116.0.1938.62)
    Internet Explorer: 11.0.22621.1

Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug.

jamespohalloran commented 1 year ago

I just opened a PR that upgrades Tina, but also fixes an issue with the date field in posts. To fix in your local repo, you can probably just update this line: https://github.com/tinacms/tinasaurus/pull/9/files#diff-f49256b71dfc7711f6f7e7e91d2624e8a13679b215db8f75ee227700a9451822R111

hrueger commented 1 year ago

Hi @jamespohalloran, thanks for the response. I did the same changes in my repo, selecting a field in the datepicker works now. However, problem 2 (crash when typing) is still an issue...

jamespohalloran commented 1 year ago

@hrueger Have you tried upgrading the Tina packages like I've done in the PR as well? I'm unable to reproduce the crash, but could be a Windows-specific thing

hrueger commented 1 year ago

Yes, I did. Here's the project: https://github.com/Dein-Ticket-Shop/docs/ When I select everything in the field, clear it and then type a letter, it crashes. I don't think it is windows-related since it is a clientside js error. Do you need a video?

jamespohalloran commented 1 year ago

@hrueger A video would be helpful if you wouldn't mind!

hrueger commented 1 year ago

Hi @jamespohalloran, sure, no problem. Here you go:

https://github.com/tinacms/tinasaurus/assets/18656830/2473dc74-27f3-4250-b557-82f833ef4634

just before it crashed, I was typing an "a". You can't see that in the video.

Does that help?

tinacms / tinasaurus