nus-se-bot
commented
2 months ago [IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]
Team's Response
I believe that it was because we didnt check the start time of a task must be before the end time (like the one shown in todaytasks), thus, the check for whether two tasks clash mess up.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
time issues with adding tasks
When I decided to add a new Task with an incorrect start and finishing time (mixed the ending with the start time), the method incorrectly saves it to the text file. Perhaps, one could create if statements to deal with invalid start and end times?
[original: nus-cs2113-AY2324S2/pe-interim#2321] [original labels: type.FunctionalityBug severity.High]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
No details provided by team.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your reason]
For the following task, 'AddTask', I tried inserting two different tasks the same day at times that didn't clash but unfortunately there was an error in the adding the task. I received the error feedback of "The task you want to add clashes with existing tasks. Please check again." but I believe it could have been more clear of what the issue was since logically there aren't any errors. Perhaps, one could add more exception handling or rewrite part of the code that deals with clashing tasks?