search

tinco / nobrainer_streams

A temporary gem that implements streams in NoBrainer, hopefully it gets merged soon and this gem will be obsolete.
MIT License
8 stars 4 forks source link

Update nobrainer_streams.gemspec #4

Closed zedtux closed 6 years ago

zedtux commented 6 years ago

Fixes homepage URL

tinco commented 6 years ago

Thanks! Did you use this?

zedtux commented 6 years ago

What do you mean @tinco ?

tinco commented 6 years ago

@zedtux I meant whether you are using the gem for anything :) I made it to accompany a blog post, but I don't think it's very suitable for production use, and I'm not sure if I should continue work on it sometime.

zedtux commented 6 years ago

@tinco oh I see. Well there's nowhere a mention of that in the README.md file and to be honest I followed what was written from Using Rails 5 ActionCable and RethinkDB to build a Reactive WebSocket App. (There are some other links referring to this gem like Multi-User Spreadsheets with ActionCable: Part 2)

Actually it is working well, didn't see any weird behaviours.

Why do you say it is not production ready?

tinco commented 6 years ago

Thanks, it's nice to know it works well for you. I can't think of any reason it wouldn't work right now, but since the gem consists of two monkey patches against internal APIs of two projects, there's a good chance at some point one of those projects makes a change that breaks this gem.

So if you've built some production code that depends on this, then you could be stuck on an old version.

Also, I think one of the reasons the patch was not accepted in the NoBrainer project is because of a possible conflict with the Rails API, I was thinking of a better design of the patch, but then my personal life got in the way and has prevented me from working on this for the past year.

If you're just building a proof of concept then there's no problem using this gem, you can always decide to put a redis server in between, or fix any problem with this gem later on.

zedtux commented 6 years ago

Well for now, the project that use this gem is not used in prod, but I don't know if it will go to prod or not.

I would then worry more about the people reading the articles I've shared and building their apps using your gem.

tinco commented 6 years ago

Thanks for the feedback, I've added a warning to the readme.

zedtux commented 6 years ago

You should probably consider opening an issue on your project explain what should be done in order to implement this gem in the right way and avoid this unstable status of this gem, don't you think?