search

tinderjs / tinder-desktop

Use Tinder from your desktop, for Mac OS X, Microsoft Windows and Linux
https://tinderjsblog.herokuapp.com/
97 stars 25 forks source link

Bug for signing out #129

Closed mayeaux closed 8 years ago

mayeaux commented 8 years ago

I'm skeptical about the token invalidation. I seem to get logged out of tinder-desktop everytime I check it, whereas in the past I could have it run for hours and hours without an issue. I think we're going a bit gung-ho on thinking the token is invalid and logging the user out, it definitely has broken usability in a pretty big way. Worth taking a look at / fixing

mayeaux commented 8 years ago

https://github.com/tinderjs/tinder-desktop/pull/91/files

Here's where the bug was introduced

It doesn't matter if the FB token expires, the xAuthToken that's returned is much more hardy anyways and that's what's used to call the API

mayeaux commented 8 years ago

Fixed in latest commit.

There should be functionality that detects when a token expires but this isn't it. The xAuthToken we get from Tinder lasts a long time, we rarely have to change it.