search

tinderjs / tinder-desktop

Use Tinder from your desktop, for Mac OS X, Microsoft Windows and Linux
https://tinderjsblog.herokuapp.com/
97 stars 25 forks source link

Instagram and spotify info on profile #160

Closed rolandbobek closed 7 years ago

rolandbobek commented 7 years ago

I filled up the profile page with infos what are in the original tinder app like: common interests common friends on facebook instagram photos spotify theme track

TODO: set translations in the localization files for new constants TODO: make a carousel to see instagram photos larger when clicked

mayeaux commented 7 years ago

Awesome, I'll check this out in the morning , thanks a lot!

rolandbobek commented 7 years ago

You're welcome! By the way, by 'carousel' in the TODO section I meant 'lightbox (modal image gallery)'. I'm sorry, it was 3AM.

rolandbobek commented 7 years ago

Screenshots of features implemented.

Instagram: the profile picture is clickable and leads to instagram profile. The show more button shows ten more pictures, until the user has more.

Spotify: artists name and song title, album artwork. preview link opens the track in a new window.

Common connections: common facebook friends with name and profile picture.

Common interests: facebook pages you both liked

tinder-feature-1 tinder-feature-2

mayeaux commented 7 years ago

Okay I've finally had a chance to check this out, here's my thoughts:

screen shot 2017-01-09 at 2 26 21 pm

I'm a little worried because the instagram photos overflow the visible page, and cause the user to have to scroll. We may want to redesign the frontend a bit so that we use the real estate under the main image, but otherwise the functionality is really great, nicely done.

Common connections was definitely needed, that's perfect.

Why do we only load 30 instagram photos? Would be great if we could do even more.

Also, we can stick Common Interests outside of the main view (stick it in the overflow space) since it's not that big of a deal.

so, tl;dr : common interests and spotify out of the main view as it's unimportant. maybe we load more instagram photos? also, the clincher for me would be, can we set up the instagram photos such that we can click on one and load it in the main view? that would be a great feature.

overall top notch work, happy to get this into the codebase!

mayeaux commented 7 years ago

Also, let's add this to the profile page so it's not just on the swipe page!

I'm closing this PR (merged these changes into a branch called 'development', once we get things looking ready for 'prod' there, we can merge it into master)

rolandbobek commented 7 years ago

Thanks! I'm afraid the 30 instagram photo limit comes from tinder itself. Later I will share my thoughts and ideas to be discussed and then I can implement the changes.