tinderjs / tinder-desktop

Use Tinder from your desktop, for Mac OS X, Microsoft Windows and Linux
https://tinderjsblog.herokuapp.com/
97 stars 25 forks source link

Better Instagram integration #41

Open SaturnusDJ opened 8 years ago

SaturnusDJ commented 8 years ago

At this moment when clicking a Instagram username, a new window opens. That's okish, but the connection made to that Instagram page is public, so to say, instead of through Tinder. Some users have their pictures hidden from public. We can't see their pictures using Tinder Desktop, but we can using Tinder mobile. So we should add code that opens Instagram of the person the same way as Tinder mobile does.

Not a top priority issue, I know, but it's listed now before forgetting.

mayeaux commented 8 years ago

Interesting. So you're saying when Tinder mobile app displays instagram pics, it will show photos of people whose profiles are private?

SaturnusDJ commented 8 years ago

That's right. Double checked 10 seconds ago.

mayeaux commented 8 years ago

Wonder how they do it. Have pinged @run1t to possibly check out

SaturnusDJ commented 8 years ago

Wild guess: User gives permission by linking Instagram, then Tinder receives some kind of token which they embed in a user profile. Then we send the token to Instagram and receive the content. Some kind of API access. But that's not my expertise.

mayeaux commented 8 years ago

The first part of fetching a token is correct, through oAuth. But there's no way that token is passed to the client via the server. Probably tinder presents that token to instagram and then serves the thumbnails to the client.

run1t commented 8 years ago

I will do that in 2 days I think

mayeaux commented 8 years ago

Lol these things are so low priority in my opinion though. :( Up to you guys ultimately what to work on but I think there's way, way more relevant things

run1t commented 8 years ago

If we take for a example a profile who have a instagram account linked if you go to the mobile client you have only 30 photos and after a link to the account of the user. Maybe the privates photos are in this 30 photos, if it's that, this will be enough :

client.getUser('userId',function(err,data){
    console.log(err);
    console.log(data.results.instagram.photos);
  });

otherwise after to those 30 photos, it's a redirect to the instagram app. So I don't think that we can get all the privates photos of user, by the way if it's possible it's very weird that instagram allow that. Hope it will help you :)

SaturnusDJ commented 8 years ago

Sounds nice. Might be good to decide what we will do with this because it would take up quite some space when we do want the Instagram thumbnails integrated in the front end like Tinder mobile.