search

tindzk / seed

Build tool for Scala projects
https://tindzk.github.io/seed/
Apache License 2.0
238 stars 13 forks source link

generation/Bloop.scala: use full scala.js version #71

Closed nafg closed 4 years ago

nafg commented 4 years ago

As of https://github.com/scalacenter/bloop/pull/1097, it is necessary to output the full version

nafg commented 4 years ago

(note: I haven't tested this change)

tindzk commented 4 years ago

Thanks for the contribution!

I reran the tests which are passing now. There was not enough memory available on the server, so the Bloop process got killed while running the integration tests.

Could you please add a test case such that we can avoid regressions?

For example, you could add these lines to the test "Build project with overridden compiler plug-in version" in BloopIntegrationSpec:

val js = exampleJs.project.platform.get.config.asInstanceOf[JsConfig]
assertEquals(js.version, "0.6.26")
tindzk commented 4 years ago

FYI The compilation failed. It looks like the import was missing.