Binary version of Scala.js turned to "1", not "1.0" as of version 1.0.0

tindzk / seed

Build tool for Scala projects

https://tindzk.github.io/seed/

Apache License 2.0

238 stars 13 forks source link

Binary version of Scala.js turned to "1", not "1.0" as of version 1.0.0 #91

Closed dtw-waleee closed 4 years ago

dtw-waleee commented 4 years ago

This leads to errors when retrieving artifacts in the form of eg.: Could not resolve dependency slinky-core_sjs1.0_2.13 in me.shadaj

Mill had to change some hardoded cases, which I guess is the case for seed too?

tindzk commented 4 years ago

Thanks for the bug report! I have merged a fix. Feel free to try it with the latest pre-release.

Please note that Seed does not officially support Scala.js v1.0 modules yet because Bloop v1.3.2 cannot link them. Once the next stable Bloop version has been released, I am hoping to add integration tests.

dtw-waleee commented 4 years ago

Great! I did a smaller more hackish workaround in seed on my local machine, but I ran into the bloop issue, so I didn't think it merited a pull request.