html-proxy isn't replaced

[ignoreigor]

Hi,

having a look on 2024.12.x , I noticed one little thing: in addressbook's detail-pane or in calender-app when showing appointment details and attendees, some html-proxies aren't replaced in titles of contact's details or attendee information. Other contacts are shown correctly.

<em id="html-proxy-20000" class="html-proxy"></em> (some.mail@address.com)

Addressbook:

Calendar:

Looking for the difference between working an wrong contacts, I first thought it was caused by missing displaynames, but displaynames were always set and the entries are looking similar in the database. The crucial hint was not to look for something missing but something additional! Only contacts with mail addresses are affected. When mail addresses are displayed in these places, something seems so fail.

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Comment or remove the stale label. Otherwise, it will be closed in 7 days.

[ignoreigor]

Still the same behaviour in weekly-2024.17.1

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Comment or remove the stale label. Otherwise, it will be closed in 7 days.

[ignoreigor]

There isn't any fix in weekly-2024.22.1 for that issue.

[pschuele]

hi, I can't reproduce this behaviour. it would be great if you could send me the json representation of one of the "broken" contacts / attendee.

[ignoreigor]

hi, I can't reproduce this behaviour. it would be great if you could send me the json representation of one of the "broken" contacts / attendee.

Hi,

of course. Here is the json-object from Michael Mustermann, I edited some personal data in created_by manually. It was created with latest weekly-2024.24.1 mustermann.json

Deleting the mail-address, i get the following json and contact is display correctly mustermann_ohne_mail.json

[ignoreigor]

I did some debugging, using Tinebase-3d8ac0412730ebd551d6-FAT.js

Problem is, in function replaceDomProxy(html)
const el = doc.getElementById(this.id); returns null, in cases the proxy is not replaced.

That is affected by the replaced element, normally <em id="html-proxy-1" class="html-proxy"> ,which is already html-encoded and no longer an element but <em id="html-proxy-1" class="html-proxy"></em> when showing an email-address. So it can't be replaced and the html-source remains visible in frontend.

[pschuele]

thanks for the debugging @ignoreigor @ccheng-dev can you have a look at this problem?

[pschuele]

we are working on a fix, coming for 2024.11 and the weekly releases.

[pschuele]

fixed with https://github.com/tine-groupware/tine/commit/aaf0c40ec3e0c5add9660092dced9f78e9859280

[ccheng-dev]

here is the result after fix :

[ignoreigor]

Looks great. Thank you for fixing. I'll have a look at the next weekly, as I am too lazy to build it myself.

Edit: weekly-2024.28.1 does work as it should.