search

tine-groupware / tine

tine groupware main repository
https://www.tine-groupware.de
GNU Affero General Public License v3.0
14 stars 2 forks source link

WebDAV Fixes for important clients such as Gnome, Windows #65

Closed lab-at-nohl closed 2 months ago

lab-at-nohl commented 4 months ago

Currently WebDAV is broken, directory listing fails on missing HTTP_CONTENT_LENGTH and GET requests are routed by Expressive instead of WebDAV (added definite routing to already existing fixes).

Adding rewrites is only a temp solution imho, routing needs some work. JN

CLAassistant commented 4 months ago

CLA assistant check
All committers have signed the CLA.

lab-at-nohl commented 4 months ago

CLA is already signed - years ago.

lab-at-nohl commented 4 months ago

Supposed to fix https://github.com/tine-groupware/tine/issues/6.

lab-at-nohl commented 4 months ago

I had to add some tweaks to get recent iOS app running (done). Tested WebDAV with Android, iPhone and Tine Drive (Linux). Also native Windows, Gnome (gvfs). All works.

The commit 14beb4f was a mistake, maybe you can merge all my commits (sorry, I am not so good with git).

pschuele commented 3 months ago

@paulmhh can you have a look? maybe we also need to adjust the rewrite rules for nginx?

pschuele commented 3 months ago

and thx @lab-at-nohl for the PR :)

pschuele commented 3 months ago

@lab-at-nohl could you please rebase the PR? we already worked on some of the files in the meantime ...

lab-at-nohl commented 3 months ago

Rebase to ...?

I am not so familiar with git, but I will do it at the next to the following weekend. Do you mean a specific branch or do you have a specific commit I should base on? Biggest challenge will be to setup a dev environment different to the actual release (I know the docker container).

Also, I can include all changes into a single commit, if you prefer...

pschuele commented 3 months ago

hi Johannes, rebase on the current main branch. as you can see in your fork, the branch of the PR is currently 89 commits behind the HEAD of the main branch:

image

you could also merge the current tine main branch into your branch if that's easier. there should be some merge conflicts that need to be resolved.

maybe some of the problems you addressed are already fixed, because we update to a current sabredav version recently.

Also, I can include all changes into a single commit, if you prefer...

that should not be necessary.

pschuele commented 2 months ago

hi, I would like to merge (at least some of) the fixes into the upstream. but this PR has to many small unrelated changes. so I would prefer, that the fixes / changes are split up into separate PRs each addressing one issue / feature. the code also needs to be rebased on the current main branch because the webdav stuff changed a lot during the sabredav upgrade.

lab-at-nohl commented 2 months ago

I am on it, the plan was to have another branch / new PR. Thus, it is possible to split, too.

Setting up a new dev environment. Please allow me a few days (weekend). I'll come back to you.

lab-at-nohl commented 2 months ago

I will do smaller PR, closing this one!