search

tinesoft / ngx-cookieconsent

Cookie :cookie: Consent module for Angular.
https://tinesoft.github.io/ngx-cookieconsent/
MIT License
164 stars 35 forks source link

Convert issue template into issue forms #116

Closed colinodell closed 3 years ago

colinodell commented 3 years ago

Resolves #115

See https://github.com/colinodell/ngx-cookieconsent/issues/new/choose for a demo of how the forms work

tinesoft commented 3 years ago

Thanks for your PR @colinodell !

Can you please address the points I raised? Thank you

colinodell commented 3 years ago

I'd be happy to address any feedback, but unfortunately I'm not seeing any specific points on this PR. Perhaps the code review wasn't submitted or something?

colinodell commented 3 years ago

@tinesoft I didn't see any feedback on the PR - would you mind re-submitting that when you get a chance? No rush on my end!

tinesoft commented 3 years ago

Hi @colinodell

(sorry I missed your first reply)

I did review your PR and submitted the desired changes (10 days ago). Please have a look at this conversation thread, you should see them.

colinodell commented 3 years ago

Weird... I don't see them at all:

screencapture-github-tinesoft-ngx-cookieconsent-pull-116-2021-10-15-23_48_54

I don't see anything in any of the other tabs either 😕

tinesoft commented 3 years ago

That's very odd indeed...🤔

Can you try this direct link? https://github.com/tinesoft/ngx-cookieconsent/pull/116#pullrequestreview-771755938

colinodell commented 3 years ago

That doesn't seem to work either, I'm afraid. It just takes me to the top of the issue :confused: I've also tried in incognito mode - same result.

tinesoft commented 3 years ago

Hi @colinodell

It looks like the request for changes was pending (not submitted)... Sorry for the inconvenience. It should be good now.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

colinodell commented 3 years ago

Ah, that would explain it :upside_down_face:

Thanks for the guidance! I've made the requested changes and force-pushed to my branch. You can review the forms here: https://github.com/colinodell/ngx-cookieconsent/issues/new/choose

tinesoft commented 3 years ago

Thanks for your PR @colinodell !

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 3.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: