search

tinesoft / ngx-cookieconsent

Cookie :cookie: Consent module for Angular.
https://tinesoft.github.io/ngx-cookieconsent/
MIT License
164 stars 35 forks source link

[Bug] Needs to be Ivy compliant [Angular 16] #134

Closed kwhjvdkamp closed 10 months ago

kwhjvdkamp commented 1 year ago

Ngx-CookieConsent Version

3.1.1

CookieConsent Version

3.1.1

Angular CLI (or Nx CLI) Version

[ng version] Angular 16.1.3

Node Version

18.16.0

OS Version

Windows 11

Expected Behaviour

Working library! It seems, I misted the fact this library seems to be a non-Ivy version. Such libraries became deprecated using Angular 16.

Is there any chance, this package is going to be upgraded, becoming Ivy compliant? Please (company Osano) let the comunity know if it stays around as a non-Ivy one. People should know, thanks.

Actual Behaviour

As notified during upgrade process Generating browser application bundles (phase: setup)... Processing legacy 'View Engine' library:

ngx-cookieconsent [es2015/esm2015] (git://github.com/tinesoft/ngx-cookieconsent.git)

Notification from Angular upgrade team: Encourage the library authors to publish an Ivy distribution

Steps to reproduce the behaviour

n/a

bardyguillaume commented 1 year ago

Hi have you got any update on angular 16 as we have incompatibility Error: node_modules/ngx-cookieconsent/cookieconsent.module.d.ts:7:53 - error NG6005: NgcCookieConsentModule.forRoot returns a ModuleWithProviders type without a generic type argument. Please add a generic type argument to the ModuleWithProviders type. If this occurrence is in library code you don't control, please contact the library authors.

7 static forRoot(config: NgcCookieConsentConfig): ModuleWithProviders;

kwhjvdkamp commented 1 year ago

Hoi!

For sure, I am NOT one of the library authors, sorry! If I could, I would! I am hampered with the same trouble upgrading to Angular 16. I am in the phase of stripping all View Libs out of the source. Everything needs to be Ivy compliant.

Cheers,

KWHJ

Van: bardyguillaume @.> Verzonden: maandag 21 augustus 2023 12:17 Aan: tinesoft/ngx-cookieconsent @.> CC: K.W.H.J. van der Kamp @.>; Author @.> Onderwerp: Re: [tinesoft/ngx-cookieconsent] [Bug] Needs to be Ivy compliant [Angular 16] (Issue #134)

Hi have you got any update on angular 16 as we have incompatibility Error: node_modules/ngx-cookieconsent/cookieconsent.module.d.ts:7:53 - error NG6005: NgcCookieConsentModule.forRoot returns a ModuleWithProviders type without a generic type argument. Please add a generic type argument to the ModuleWithProviders type. If this occurrence is in library code you don't control, please contact the library authors.

7 static forRoot(config: NgcCookieConsentConfig): ModuleWithProviders;



—
Reply to this email directly, view it on GitHub <https://github.com/tinesoft/ngx-cookieconsent/issues/134#issuecomment-1686049530> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACJWP72KXY4UXJ2S2KHSQA3XWMYQFANCNFSM6AAAAAAZ54WH7Q> .
You are receiving this because you authored the thread.  <https://github.com/notifications/beacon/ACJWP7Y2HPYJZTAXU2QHGVLXWMYQFA5CNFSM6AAAAAAZ54WH7SWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTEP4JPU.gif> Message ID: ***@***.*** ***@***.***> >
bardyguillaume commented 1 year ago

Sorry Thanks for advice I understand Not easy 😅

tinesoft commented 1 year ago

Hi guys,

Thanks for using the library and sorry for the delay in responding.... I will have a look ASAP. Stay tuned

nishchithas commented 10 months ago

Any update on this for Angular 16? Has any one found work around for this issue?

tinesoft commented 10 months ago

Hi guys!

Sorry for the delay in fixing this. I have been busy with work + other oss projects...

But bear with me a bit longer, I will start updating the library to support modern angular, later this week

Stay tuned!

kwhjvdkamp commented 10 months ago

No! Unfortunately not! Trouble, trouble, trouble. Skipped this cookie-stuff... ...doesn't run on Angular 16, also many other things broken! Tried to rebuild the whole thing. Base site finally runs on Angular 17, however another problem, now stucked on getting firestore running in Angular 17. Still many complications between packages.

Actually, lost motivation to get it repaired.

nishchithas commented 10 months ago

@kwhjvdkamp

No! Unfortunately not! Trouble, trouble, trouble. Skipped this cookie-stuff... ...doesn't run on Angular 16, also many other things broken! Tried to rebuild the whole thing. Base site finally runs on Angular 17, however another problem, now stucked on getting firestore running in Angular 17. Still many complications between packages.

Actually, lost motivation to get it repaired.

What is the alternative you are using in Angular 17?

nishchithas commented 10 months ago

@tinesoft Any updates?

kwhjvdkamp commented 10 months ago

...finally able to get my site up-and-running again, able to fetch data from from the firestore cloud ! With that having said, it's running without cookie-stuff, service-worker, internationalization (including left-and-right orientation). I had to remove these functionality also some other stuff based on HighCharts.

I really don't no what has changed ! I was - after many trial-and-errors - able to build and deploy it to firebase, however only in the development mode. I seems to be able to build a production version however it can't be deployed due to mime errors on the script package, in the production flow need to tweek manually the index.html from the dist-folder; it's looking into the wrong sub folder, so I need to tweak manually the path to the scripts packages and surpringly if I got that fixed, it won't build a styles-package. It became really 'whipped cream' between my ears!

So, overnight, I took the short corner, gambled on the fact being able to deploy the latest develop-version! So, luckily the basic side is running (not the version it should be, but)... ...oh wel!

Did not have any second left to dive into reimplement cookie-stuff

https://consult-koen.web.app/#/home

tinesoft commented 10 months ago

Hi guys,

Hang tight! I've just released v5.0.0 ( fully compatible with Angular 15 + added support for standalone API).

I will check for compatibility with Angular 16 and beyond, (hopefully tonight) and perform subsequent releases if needed.

Until then, you can try out this new version and report here if you have issue....

kwhjvdkamp commented 10 months ago

Hi, thanks !

However, may bring up this... image !

tinesoft commented 10 months ago

@kwhjvdkamp Looks like a configuration issue on your side (probably the provided cookie.domain URL) . The demo app (built with Angular v15 for now) does not give this warning... Can you share your config?

Btw, Is your original Ivy compilation issue solved ?

kwhjvdkamp commented 10 months ago

Hi Tine, No not solved! I decided to get rid of every IVY-related deprecated code. With that said; service-worker, internationalization and cookie stuff. Also several HighCharts aren't working anymore. I needed my base up-and-running, for now its acceptable. Need to continue with other things...

tinesoft commented 10 months ago

Ok, thanks for the info.

I will certainly release a v6.0.0 (compatible with Angular >=16) later today...

github-actions[bot] commented 10 months ago

:tada: This issue has been resolved in version 6.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

tinesoft commented 10 months ago

https://github.com/tinesoft/ngx-cookieconsent/releases/tag/v6.0.0 was released with support for Angular 16+

@kwhjvdkamp can you give it a try and let me know if everything OK ?

kwhjvdkamp commented 10 months ago

@tinesoft TineKondo

Guigeek973 commented 1 month ago

Hello, i'm now using angular 18 and it seems to don't work anymore, can't understand why... Is any people has the same issue ? What was the change between 16 to 18 that broke (again) the package ?

kwhjvdkamp commented 1 month ago

No! It’s working. Review carefully your changes!

Van: Guigeek973 @.> Verzonden: maandag 28 oktober 2024 08:56 Aan: tinesoft/ngx-cookieconsent @.> CC: K.W.H.J. van der Kamp @.>; Mention @.> Onderwerp: Re: [tinesoft/ngx-cookieconsent] [Bug] Needs to be Ivy compliant [Angular 16] (Issue #134)

Hello, i'm now using angular 18 and it seems to don't work anymore, can't understand why... Is any people has the same issue ? What was the change between 16 to 18 that broke (again) the package ?

— Reply to this email directly, view it on GitHub https://github.com/tinesoft/ngx-cookieconsent/issues/134#issuecomment-2440792606 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJWP7Z5CXJP7RUHZBIQ2NDZ5XNWNAVCNFSM6AAAAABQWZZ7MWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBQG44TENRQGY . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ACJWP7Y7WFDTLV73CM7V2WLZ5XNWNA5CNFSM6AAAAABQWZZ7MWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTURPOFB4.gif Message ID: @. @.> >