search

tinesoft / ngx-cookieconsent

Cookie :cookie: Consent module for Angular.
https://tinesoft.github.io/ngx-cookieconsent/
MIT License
161 stars 34 forks source link

Support for SameSite property #94

Open moodymood opened 3 years ago

moodymood commented 3 years ago

Request Ttype

- [ ] bug report -> please search issues before submitting
- [x ] feature request

CookieConsent and Library Versions

- cookieconsent version: 3.1.1
- ngx-cookieconsent version: 2.2.3

The log

On Firefox Cookie “cookieconsent_status” will be soon rejected because it has the “SameSite” attribute set to “None” or an invalid value, without the “secure” attribute. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite

Desired functionality

Allow setting SameSite property in NgcCookieOptions https://tinesoft.github.io/ngx-cookieconsent/doc/classes/NgcCookieOptions.html

tinesoft commented 3 years ago

Waiting for https://github.com/osano/cookieconsent/pull/734 to be merged and v4 to be released, so I can add this option on ngx-cookieconsent...

MatheusDaros commented 2 years ago

@tinesoft could you pick up from https://github.com/Enaah/cookieconsent/tree/fix-cookie--no-sameSite-attribute ?

alexantonica commented 5 months ago

Interested in this as well. Any updates?