tinesoft / ngx-scrollreveal

Angular directives for ScrollReveal : a JavaScript library for easily animating elements as they enter/leave the viewport.
https://tinesoft.github.io/ngx-scrollreveal
MIT License
93 stars 11 forks source link

Cannot use NgsRevealModule Module in Angular 16 #155

Open turboaux opened 1 year ago

turboaux commented 1 year ago

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

OS and Version?

Versions

MacOS Big Sur 11.6

Angular CLI: 16.1.1 Node: 18.13.0 Package Manager: npm 8.19.3 OS: darwin x64

Angular: 16.1.2 ... animations, common, compiler, compiler-cli, core, forms ... platform-browser, platform-browser-dynamic, router

Package Version

@angular-devkit/architect 0.1601.1 @angular-devkit/build-angular 16.1.1 @angular-devkit/core 16.1.1 @angular-devkit/schematics 16.1.1 @angular/cli 16.1.1 @schematics/angular 16.1.1 rxjs 7.8.1 typescript 5.1.3

Repro steps

Run the app:

The log given by the failure

Error: src/app/app.module.ts:15:5 - error NG6002: 'NgsRevealModule' does not appear to be an NgModule class.

NgsRevealModule,
   ~~~~~~~~~~~~~~~

node_modules/ngx-scrollreveal/ngs-reveal.module.d.ts:6:22

export declare class NgsRevealModule {
                       ~~~~~~~~~~~~~~~
This likely means that the library (ngx-scrollreveal) which declares NgsRevealModule is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

From Angular 15 I get this when compiling.

Generating browser application bundles (phase: setup)...Processing legacy "View Engine" libraries:

niamat-bakhshi commented 10 months ago

As per the documentation, it shoud work for Angular 6+. However, it doesn't. My Angular is 17. It throws exactly the same error.

XSiya commented 9 months ago

@turboaux @niamat-bakhshi anyone know what the complexity is with supporting Ivy so we can push a PR?