tingbot / tide-electron

šŸ“ Ā  Simple IDE for developing Tingbot apps
Other
22 stars 7 forks source link

Make file/feature #15

Closed StefanJanssen95 closed 8 years ago

joerick commented 8 years ago

Hi Stefan

Thanks for this - I think the main thing this PR is doing is allowing Windows/Linux to open tingapps. Unfortunately we canā€™t remove the .tingapp extension from the containing folder, because we need to maintain compatibility with the Mac app, and some workings of the Tingbot OS thatā€™s being developed separately.

So my suggestion for this would be to keep the .tingapp extension on the folder but add a ā€˜sentinelā€™ or ā€˜metafileā€™ to the project thatā€™s what the Windows/Linux open dialogs will select. But! It can also be used to hold information used by the Tingbot OS (name and version), and perhaps the Tingbot Ocean (author, URL). We donā€™t need to decide the exact schema of that yet though, probably just ā€˜nameā€™ will do for now :)

To be found by the OS, it will have to always have the same name within a Tingapp. Previous designs of this had the file called info.json, but since this file is selected from the dialog it should have a more obvious name and district extension - I like your suggestion of <appname>.tingapp, but it needs to have a different extensionā€¦

^ just some ideas for what to call it. I think app.tbinfo makes the most sense to me.


p.s. Looks like there are a few things that this pull request is changing - itā€™s normally better to keep pull requests to just one issue - more and it gets hard to review effectively. Specifically unrelated renames and style changes should be avoided (unless thatā€™s the point of the pull request).