search

tingbot / tingbot-python

🔩 Python APIs to write apps for Tingbot
Other
18 stars 9 forks source link

Enable development of a gui library #12

Closed furbrain closed 8 years ago

furbrain commented 8 years ago

There are a few changes here - changes to MANIFEST.in, docs/conf.py, docs/reference.rst, and tingbot/error.py are all minor bug fixes

Changes to input.py allow the addition of an input handler to intercept touch events (vital if we are to implement modal windows such as dropdown controls and message boxes). The current functionality of this file is unchanged, simply extended, so this should be backward compatible with any code already written

joerick commented 8 years ago

Hey @furbrain, thanks for this. Sorry for the delay!

Quick question on the [un]set_modal_handler - is this designed to allow GUI dialogs over the top of apps that use basic drawing? Because I was thinking that it could be handled within the GUI module if it's just for GUI apps?

furbrain commented 8 years ago

[un]set_modal_handler - this is indeed to allow GUI dialogs on top of basic drawing apps.

joerick commented 8 years ago

[un]set_modal_handler - this is indeed to allow GUI dialogs on top of basic drawing apps.

Cool, that makes sense. Could we change the names to push_touch_handler and pop_touch_handler?

furbrain commented 8 years ago

Ok, have refactored [un]set_modal_handler to [pop|push]_touch_handler (and also modal_handlers -> touch handlers)

joerick commented 8 years ago

Merged! Thanks for your patience with this!