search

tingerrr / hydra

A typst package for displaying the active section in the page header or footer.
MIT License
26 stars 3 forks source link

Filter candidates defined after the current page #21

Closed freundTech closed 3 months ago

freundTech commented 3 months ago

Previously when both prev and last candidates were none hydra would show candidates defined on later pages. I believe that candidates defined on pages after the current page should never be displayed.

freundTech commented 3 months ago

Or should this be configurable? I personally can't think of any option why one would want to display a heading defined on a later page. You basically already signed off on this in https://github.com/tingerrr/hydra/pull/19#discussion_r1659648664, but through the restructuring of that PR it was changed to only affect last candidates, which I think was a mistake.

freundTech commented 3 months ago

Force pushed to fix typo in commit message.

tingerrr commented 3 months ago

Unfortunate that it slipped through my review, thank you! Could you update the changelog to reflect that fix with a link to the PR (i.e. #21)?

That would go under a new ## Fixed section.

freundTech commented 3 months ago

Done!

tingerrr commented 3 months ago

Thank you!