tinghuiz / SfMLearner

An unsupervised learning framework for depth and ego-motion estimation from monocular videos
MIT License
1.96k stars 555 forks source link

Undefined name: from scipy.interpolate import LinearNDInterpolator #120

Closed cclauss closed 3 years ago

cclauss commented 5 years ago

LinearNDInterpolator() is called on line 122 but it is never defined or imported.

flake8 testing of https://github.com/tinghuiz/SfMLearner on Python 3.7.1

$ flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics

./kitti_eval/depth_evaluation_utils.py:121:9: F821 undefined name 'LinearNDInterpolator'
    f = LinearNDInterpolator(ij, d, fill_value=0)
        ^
./kitti_eval/pose_evaluation_utils.py:187:25: F821 undefined name '_FLOAT_EPS_4'
            cy_thresh = _FLOAT_EPS_4
                        ^
./kitti_eval/pose_evaluation_utils.py:210:21: F821 undefined name 'atan2'
                x = atan2(r12, r13)
                    ^
3     F821 undefined name 'LinearNDInterpolator'
3

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.