search

tingkai-mai / pe

0 stars 0 forks source link

Invalid Date for Leap Years #2

Open tingkai-mai opened 1 year ago

tingkai-mai commented 1 year ago

Issue: When adding a review, you can add the date 29 January 2001. However, as 2001 is not a leap year, 29 January does not exist. An error or warning should be fed back to the user to signal an invalid date.

To reproduce: radd s/1 d/29/01/2001 c/TEST r/1

Expected Output: Some kind of error signalling invalidity of date

Actual Output: Review is added

nus-se-script commented 1 year ago

Team's Response

Do check the 2022 calendar for a 29th January. It turns out 29th January is in every year.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]