nus-se-bot
commented
1 year ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Allowing editing even if there is no change
Type in "sedit 1 n/n a/a t/"for 2 times consecutively, the response message just shows the editing is allowed. It is better that shows message like "nothing is changed..". And I think there is a filter in AB3 source code which check for whether there is any change made during editing.
[original: nus-cs2103-AY2223S1/pe-interim#1078] [original labels: type.FeatureFlaw severity.Low]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
And I think there is a filter in AB3 source code which check for whether there is any change made during editing.
AB3 does not have this feature
Currently, this is the intended behavior for FoodWhere.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
:question: Issue response
Team chose [response.NotInScope]
- [x] I disagree
Reason for disagreement: This should not be an intended behaviour, because the Edit command, by its namesake, should be changing a Stall from one set of attributes to another set of attributes.
:question: Issue type
Team chose [type.FeatureFlaw]
Originally [type.FunctionalityBug]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
Issue:
You can edit a Stall information without having any fields changed. For example, editing a stall with name "Z" to "Z" is allowed. Some warning or note should be raised, considering that at least one field must be provided to be edited. For example,
seditis not allowed. So, why issedit n/sameNameallowed?To Reproduce:
Simply run the
seditcommand and copy over the same name.Expected Output:
Some error should be raised when this occurs.
Actual Output:
Editing is allowed.