search

tingkai-mai / pe

0 stars 0 forks source link

Random Delimiters Causes Error After r/ Delimiter #5

Open tingkai-mai opened 2 years ago

tingkai-mai commented 2 years ago

Issue:

When adding random delimiters that do not exist in the User Guide, an invalid error message is raised. This occurs when you try to do so after the "r/" delimiter, which confused me initially when I made the mistake.

This is a medium severity bug as because if I am an inexperienced user who misinputted a delimiter (one that does not exist) after the "r/" delimiter, I am presented with "Ratings can take any integer between 0 to 5, and it should not be blank" output.

To Reproduce:

radd s/1 d/11/11/2022 c/test r/4 a/test

Expected Output:

Some error message stating that there is no such delimiter "a/".

Actual Output:

Ratings can take any integer between 0 to 5, and it should not be blank

nus-pe-script commented 1 year ago

Team's Response

This is explained in the user guide. r/4 a/test, the a/ flag is an extraneous parameter that is interpreted as part of the previous parameter. 4 a/test is not a valid rating.

This is considered a Low as it causes a minor inconvenience only.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: You agreed that this is considered a Low, so why was this rejected?

In addition, this SHOULD be a bug, because the error message is not sufficiently informative. What if I did not know this? The error message does not indicate that the a/ flag is an extraneous parameter that is interpreted as part of the previous parameter.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]