tinify / tinify-python

Python client for the Tinify API.
https://tinypng.com/developers
MIT License
131 stars 21 forks source link

Modernizing #11

Closed daxm closed 4 years ago

daxm commented 4 years ago

I don't know if you will like this or not but I tried to "modernize" this code. There are other things I'd like to see done (like moving the tinify() class out of init) but I lack the skill level to do that. All that said, I basically:

I don't have a fancy way to test but I was able to successfully optimize (and resize) a sample image with the code in this PR.

emielvanlankveld commented 4 years ago

Hi! Thank you for the effort you put into modernising the code.

At this time we don't see a great reason to explicitly drop Python2 support. When we expand the feature set of the package we are definitely not against updating the minimum requirements if it makes development easier.

We'll definitely revisit this PR when we next work on the package and can merge it if it makes sense at that time. Thank you again!