tink-crypto / tink-go

Go implementation of Tink
https://developers.google.com/tink
Apache License 2.0
113 stars 5 forks source link

aead/subtle: change bazel visibility to public #5

Closed derpsteb closed 10 months ago

derpsteb commented 1 year ago

Copied from https://github.com/google/tink/pull/718:

Hey. Thanks for the nice library!

We want to use aead/subtle in a project that is built with Bazel. However, aead/subtle's default visibilty stops us from doing that. I understand the docs in a way that suggests using subtle pkgs is intended use; keeping in mind that extra care is required. Thus, add public visibility on the Bazel level, just like kwp/subtle does it.

Cheers.

morambro commented 11 months ago

Thanks for this PR, this LGTM. Could you please sync to main before I go ahead and merge it?

morambro commented 10 months ago

This was done in https://github.com/tink-crypto/tink-go/commit/b0b39f1d46298e5e4203321f11cff166042aff1a