search

tink-crypto / tink

Tink is a multi-language, cross-platform, open source library that provides cryptographic APIs that are secure, easy to use correctly, and hard(er) to misuse.
https://developers.google.com/tink
Apache License 2.0
13.5k stars 1.18k forks source link

386 Go AEAD GCM build is broken #590

Closed Dheu3 closed 2 years ago

Dheu3 commented 2 years ago

Describe the bug:

Running Go 1.16.3 with GOARCH=386 results in compile error:

go@1.6.1/aead/subtle/aes_gcm.go:115:7: constant 68719476704 overflows int

What was the expected behavior?

Either the compile works or the readme clearly states what platforms are supported.

How can we reproduce the bug?

GOARCH=386 go test ./...

Do you have any debugging information?

go@1.6.1/aead/subtle/aes_gcm.go:115:7: constant 68719476704 overflows int

Provide your version information:

rohansingh commented 2 years ago

This is addressed in #579 but it needs review.

chuckx commented 2 years ago

Fixed by ad6cadb9bfb999687046049591852fc2bb96198c.